Skip to content

🐛 (expo): Fix download item heights#840

Merged
aaronleopold merged 1 commit intostumpapp:experimentalfrom
Arklaum:fix-download-item-heights
Dec 8, 2025
Merged

🐛 (expo): Fix download item heights#840
aaronleopold merged 1 commit intostumpapp:experimentalfrom
Arklaum:fix-download-item-heights

Conversation

@Arklaum
Copy link
Copy Markdown
Collaborator

@Arklaum Arklaum commented Dec 4, 2025

The DownloadRowItem's have different heights depending on the title having one or two lines, which makes things look uneven when using thumbnail ratio 1:1.41 or 1:1.5:

Before vs After
Before  After  
1 3
2 4
In "After" the thumbnails/download row items look taller because I use thumbnail 1:1.41, but if you use 1:1.5 they're near identical to before (~2px taller). All explained below.

Up until now all widths have been fixed with height varying based on the thumbnail ratio, because that worked well for the grids and horizontal lists. But these should probably use a fixed height with varying widths, so I've done that.

Now with all thumbnails being the same height regardless of aspect ratio, the actual fix is just to reduce the padding slightly, but there are other ways if you prefer (like reducing text size or line spacing).


Also I've used useMemo the same way it's used in useListItemSize, but they're cheap calculations so doesn't it actually hurt performance? Maybe we can just enable the React Compiler at some point to not need to think about these things ever again?

@Arklaum Arklaum changed the title 🐛 fix DownloadRowItem heights 🐛 (expo): Fix download item heights Dec 4, 2025
Copy link
Copy Markdown
Collaborator

@aaronleopold aaronleopold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I didn't get to this earlier over the weekend, but this looks great! Thank you!


Maybe we can just enable the React Compiler at some point to not need to think about these things ever again?

Yeah 100%, I've been meaning to give it a try. I started a wip branch here if you're interested: https://github.com/stumpapp/stump/tree/unstable-dependency-upgrades

@aaronleopold aaronleopold merged commit 7570aaa into stumpapp:experimental Dec 8, 2025
7 checks passed
@Arklaum Arklaum deleted the fix-download-item-heights branch December 9, 2025 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants