🐛 (expo): Fix download item heights#840
Merged
aaronleopold merged 1 commit intostumpapp:experimentalfrom Dec 8, 2025
Merged
Conversation
aaronleopold
approved these changes
Dec 8, 2025
Collaborator
aaronleopold
left a comment
There was a problem hiding this comment.
Sorry I didn't get to this earlier over the weekend, but this looks great! Thank you!
Maybe we can just enable the React Compiler at some point to not need to think about these things ever again?
Yeah 100%, I've been meaning to give it a try. I started a wip branch here if you're interested: https://github.com/stumpapp/stump/tree/unstable-dependency-upgrades
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
DownloadRowItem's have different heights depending on the title having one or two lines, which makes things look uneven when using thumbnail ratio 1:1.41 or 1:1.5:Before vs After
Up until now all widths have been fixed with height varying based on the thumbnail ratio, because that worked well for the grids and horizontal lists. But these should probably use a fixed height with varying widths, so I've done that.
Now with all thumbnails being the same height regardless of aspect ratio, the actual fix is just to reduce the padding slightly, but there are other ways if you prefer (like reducing text size or line spacing).
Also I've used
useMemothe same way it's used inuseListItemSize, but they're cheap calculations so doesn't it actually hurt performance? Maybe we can just enable the React Compiler at some point to not need to think about these things ever again?