Skip to content

Conversation

@NimaSarajpoor
Copy link
Collaborator

This PR is to fix #1100.

@gitnotebooks
Copy link

gitnotebooks bot commented Nov 6, 2025

Found 1 changed notebook. Review the changes at https://app.gitnotebooks.com/stumpy-dev/stumpy/pull/1101

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link
Contributor

@seanlaw seanlaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@NimaSarajpoor Did you actually execute the notebook and re-run all of the cells and pushed?

@NimaSarajpoor
Copy link
Collaborator Author

Will do and push again.

@seanlaw
Copy link
Contributor

seanlaw commented Nov 7, 2025

Looks good. Ready to merge?

@NimaSarajpoor
Copy link
Collaborator Author

NimaSarajpoor commented Nov 7, 2025

Yes. Please merge at your earliest convenience.

@NimaSarajpoor NimaSarajpoor merged commit 279cbb7 into main Nov 7, 2025
27 checks passed
@seanlaw
Copy link
Contributor

seanlaw commented Nov 7, 2025

Thanks for fixing it @NimaSarajpoor!

@NimaSarajpoor NimaSarajpoor deleted the fix-warning branch November 7, 2025 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

warning in tutorial

3 participants