Change more references to left/right in tests#265
Conversation
The issue stumpy-dev#235 has the context for this change and the suggested naming. This closes stumpy-dev#235
Codecov Report
@@ Coverage Diff @@
## master #265 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 18 18
Lines 1601 1601
=========================================
Hits 1601 1601 Continue to review full report at Codecov.
|
|
Thank you! I will take a look |
seanlaw
left a comment
There was a problem hiding this comment.
Great work @sergiobuj! This is ready to be merged.
I understand that you've had limited exposure to the codebase but I was also wondering if you had noticed anything else, in general, that could be improved? Any feedback/criticism will not be taken personally 😅
I didn't come across anything that I wanted to change immediately. I had trouble finding a couple of functions in the readthedocs site, but maybe I didn't look in the right place. I wanted to thank you for the fast responses and reviews! |
|
Awesome! Since I jumped the gun last time, is the corresponding issue ready to be closed now? |
That is good feedback. Currently, only publicly supported functions are listed in our documentation (even though we have many functions that are not preceded by |
Yes, ready to close. I believe I covered all the relevant places. |
|
Thank you again and have a wonderful weekend! |
The issue #235 has the context for this change and the suggested naming.
In this change, not all references are
ref_mp/comp_mpbutref/compin some cases. Please let me know if those still look good.This is the final change to close #235
Checklist:
./setup.sh && ./test.shin the root stumpy directory