Skip to content

Change more references to left/right in tests#265

Merged
seanlaw merged 1 commit intostumpy-dev:masterfrom
sergiobuj:sb/last_variable_changes_in_tests
Oct 8, 2020
Merged

Change more references to left/right in tests#265
seanlaw merged 1 commit intostumpy-dev:masterfrom
sergiobuj:sb/last_variable_changes_in_tests

Conversation

@sergiobuj
Copy link
Copy Markdown
Contributor

The issue #235 has the context for this change and the suggested naming.
In this change, not all references are ref_mp/comp_mp but ref/comp in some cases. Please let me know if those still look good.

This is the final change to close #235


Checklist:

  • Run ./setup.sh && ./test.sh in the root stumpy directory

The issue stumpy-dev#235 has the context for this change and
the suggested naming.

This closes stumpy-dev#235
@codecov-io
Copy link
Copy Markdown

codecov-io commented Oct 8, 2020

Codecov Report

Merging #265 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #265   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           18        18           
  Lines         1601      1601           
=========================================
  Hits          1601      1601           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea379cb...3f4df19. Read the comment docs.

@seanlaw
Copy link
Copy Markdown
Contributor

seanlaw commented Oct 8, 2020

Thank you! I will take a look

Copy link
Copy Markdown
Contributor

@seanlaw seanlaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @sergiobuj! This is ready to be merged.

I understand that you've had limited exposure to the codebase but I was also wondering if you had noticed anything else, in general, that could be improved? Any feedback/criticism will not be taken personally 😅

@seanlaw seanlaw merged commit 665bd6e into stumpy-dev:master Oct 8, 2020
@sergiobuj sergiobuj deleted the sb/last_variable_changes_in_tests branch October 9, 2020 16:38
@sergiobuj
Copy link
Copy Markdown
Contributor Author

I understand that you've had limited exposure to the codebase but I was also wondering if you had noticed anything else, in general, that could be improved? Any feedback/criticism will not be taken personally 😅

I didn't come across anything that I wanted to change immediately. I had trouble finding a couple of functions in the readthedocs site, but maybe I didn't look in the right place.

I wanted to thank you for the fast responses and reviews!

@seanlaw
Copy link
Copy Markdown
Contributor

seanlaw commented Oct 9, 2020

Awesome! Since I jumped the gun last time, is the corresponding issue ready to be closed now?

@seanlaw
Copy link
Copy Markdown
Contributor

seanlaw commented Oct 9, 2020

I had trouble finding a couple of functions in the readthedocs site, but maybe I didn't look in the right place.

That is good feedback. Currently, only publicly supported functions are listed in our documentation (even though we have many functions that are not preceded by _function_name).

@sergiobuj
Copy link
Copy Markdown
Contributor Author

Awesome! Since I jumped the gun last time, is the corresponding issue ready to be closed now?

Yes, ready to close. I believe I covered all the relevant places.

@seanlaw
Copy link
Copy Markdown
Contributor

seanlaw commented Oct 9, 2020

Thank you again and have a wonderful weekend!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Replace left, right with ref in Unit Tests

3 participants