Skip to content

Conversation

@alvii147
Copy link
Contributor

@alvii147 alvii147 commented Jul 8, 2021

The Advanced Annotation Vectors Tutorial references the previous tutorial, Annotation Vectors Tutorial in it, but the links are broken. The links should include .html at the end to work. This was added.

Pull Request Checklist

Below is a simple checklist but please do not hesitate to ask for assistance!

  • Fork, clone, and checkout the newest version of the code
  • Create a new branch
  • Make necessary code changes
  • Install black (i.e., python -m pip install black or conda install -c conda-forge black)
  • Install flake8 (i.e., python -m pip install flake8 or conda install -c conda-forge flake8)
  • Install pytest-cov (i.e., python -m pip install pytest-cov or conda install -c conda-forge pytest-cov)
  • Run black . in the root stumpy directory
  • Run flake8 . in the root stumpy directory
  • Run ./setup.sh && ./test.sh in the root stumpy directory
  • Reference a Github issue (and create one if one doesn't already exist)

The Advanced Annotation Vectors Tutorial references the previous
tutorial, Annotation Vectors Tutorial in it, but the links are broken.
The links should include .html at the end to work. This was added.
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@codecov-commenter
Copy link

codecov-commenter commented Jul 8, 2021

Codecov Report

Merging #432 (a4d1d5a) into main (f9a2c4c) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##              main      #432   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           35        35           
  Lines         2743      2743           
=========================================
  Hits          2743      2743           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f9a2c4c...a4d1d5a. Read the comment docs.

@seanlaw seanlaw merged commit 1a33e4d into stumpy-dev:main Jul 8, 2021
@alvii147 alvii147 deleted the alvii147/AV_tutorial_broken_links branch July 11, 2021 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants