Skip to content

Conversation

@NimaSarajpoor
Copy link
Collaborator

Move naive implementation to the top of test files (Ref #434)

Pull Request Checklist

Below is a simple checklist but please do not hesitate to ask for assistance!

  • Fork, clone, and checkout the newest version of the code
  • Create a new branch
  • Make necessary code changes
  • Install black (i.e., python -m pip install black or conda install -c conda-forge black)
  • Install flake8 (i.e., python -m pip install flake8 or conda install -c conda-forge flake8)
  • Install pytest-cov (i.e., python -m pip install pytest-cov or conda install -c conda-forge pytest-cov)
  • Run black . in the root stumpy directory
  • Run flake8 . in the root stumpy directory
  • Run ./setup.sh && ./test.sh in the root stumpy directory
  • Reference a Github issue (and create one if one doesn't already exist)

@codecov-commenter
Copy link

codecov-commenter commented Jul 20, 2021

Codecov Report

Merging #440 (8a052e9) into main (4c05d54) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##              main      #440   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           35        35           
  Lines         2743      2764   +21     
=========================================
+ Hits          2743      2764   +21     
Impacted Files Coverage Δ
stumpy/core.py 100.00% <0.00%> (ø)
stumpy/motifs.py 100.00% <0.00%> (ø)
stumpy/snippets.py 100.00% <0.00%> (ø)
stumpy/aamp_motifs.py 100.00% <0.00%> (ø)
stumpy/aampdist_snippets.py 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c05d54...8a052e9. Read the comment docs.

@seanlaw seanlaw merged commit 8ac6a8c into stumpy-dev:main Jul 20, 2021
@seanlaw
Copy link
Contributor

seanlaw commented Jul 20, 2021

Thank you!

@seanlaw
Copy link
Contributor

seanlaw commented Jul 20, 2021

FYI, I just added a new function to test.sh called check_naive that checks to see if there are any naive implementations that come after a test. If there is, test.sh exits with an error. See this commit

@NimaSarajpoor
Copy link
Collaborator Author

I had this idea but not the knowledge to implement it. This is great!

@seanlaw
Copy link
Contributor

seanlaw commented Jul 20, 2021

I had this idea but not the knowledge to implement it. This is great!

I didn't know either but just played around and threw something together. :)

@NimaSarajpoor NimaSarajpoor deleted the refactor_naive branch July 20, 2021 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants