Skip to content

Conversation

@gesellc
Copy link
Collaborator

@gesellc gesellc commented Sep 19, 2016

This is just a initial test. Could you verify if the install description is complete?

"It works on my machine..." :-)

@coveralls
Copy link

coveralls commented Sep 19, 2016

Coverage Status

Coverage remained the same at 59.42% when pulling 0455a01 on gesellc:protractor-spike-2016-09-19 into aa51d34 on sturmf:master.

@coveralls
Copy link

coveralls commented Sep 19, 2016

Coverage Status

Coverage remained the same at 59.42% when pulling 5a3291a on gesellc:protractor-spike-2016-09-19 into aa51d34 on sturmf:master.

Copy link
Owner

@sturmf sturmf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you hook this tests up to the travis.ci?

@coveralls
Copy link

Coverage Status

Coverage remained the same at 59.42% when pulling 9f23877 on gesellc:protractor-spike-2016-09-19 into aa51d34 on sturmf:master.

@coveralls
Copy link

coveralls commented Sep 23, 2016

Coverage Status

Coverage remained the same at 59.42% when pulling 260813d on gesellc:protractor-spike-2016-09-19 into aa51d34 on sturmf:master.

@gesellc
Copy link
Collaborator Author

gesellc commented Sep 23, 2016

Pew... so this is green now. But the travis configuration exploded. We should talk about refactoring this.

@sturmf Added you as contributor to my fork.

@coveralls
Copy link

coveralls commented Sep 24, 2016

Coverage Status

Coverage remained the same at 59.42% when pulling 4c26db0 on gesellc:protractor-spike-2016-09-19 into aa51d34 on sturmf:master.

@coveralls
Copy link

coveralls commented Sep 24, 2016

Coverage Status

Coverage remained the same at 59.42% when pulling 434fd9d on gesellc:protractor-spike-2016-09-19 into aa51d34 on sturmf:master.

@coveralls
Copy link

coveralls commented Sep 26, 2016

Coverage Status

Coverage remained the same at 59.42% when pulling 397bd95 on gesellc:protractor-spike-2016-09-19 into aa51d34 on sturmf:master.

@coveralls
Copy link

coveralls commented Sep 26, 2016

Coverage Status

Coverage remained the same at 59.42% when pulling b863edd on gesellc:protractor-spike-2016-09-19 into aa51d34 on sturmf:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 59.42% when pulling b863edd on gesellc:protractor-spike-2016-09-19 into aa51d34 on sturmf:master.

@gesellc
Copy link
Collaborator Author

gesellc commented Sep 26, 2016

How about merging this to master?

Admittedly, there are a few ways to refactor this

  • Do we really need the trusty image with sudo on Travis?
  • Should we move the different dependencies (backend, frontend, test dependencies) into scripts?

but I'd rather see how we use the protractor tests locally for development and let this usage inform future refactorings.

That way we can start test-driving new features now... :-)

@coveralls
Copy link

coveralls commented Sep 26, 2016

Coverage Status

Coverage decreased (-17.8%) to 41.667% when pulling 0dbc7e6 on gesellc:protractor-spike-2016-09-19 into aa51d34 on sturmf:master.

@sturmf sturmf merged commit bb0ee72 into sturmf:master Sep 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants