This repository was archived by the owner on Feb 4, 2023. It is now read-only.
Fix individual filtering in combination with scrollX #730
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix individual filtering in combination with horizontal scrolling byusing the Datatable instance and not a predefined ID as selector.
Bug: When individual filtering used on a table with
scrollX = truethe column filters don't work. The code in search.js.twig searches for the input & select fields in the datatable (by the id of the table). Because of the scrollX, the table has been split up in 2 different tables (e.g. one table for scrollHead and another table for scrollBody). The input fields are now outside the 'selector' and will not work.To solve this the selector should be changed to the wrapper/container. However this is different for tables with or without scrollX. Like the example on https://datatables.net/extensions/fixedcolumns/examples/styling/col_filter.html I've now used
oTable.table().container()as selector. This will work with and withoutscrollX = true.