This repository was archived by the owner on Feb 4, 2023. It is now read-only.
Fix for Multiselect Column on Symfony 4 #744
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Symfony 4's PropertyAccessor uses primary add* method for adding properties, not set*. Since MultiselectColumn is derived from ActionColumn and MultiselectColumn didn't have a addAction method, PropertyAccessor uses addAction method from ActionColumn class, that creates Action objects, not MultiselectAction objects.
Fix for multiselect actions on Symfony 4
Seb33300
reviewed
Feb 27, 2018
| { | ||
| $newAction = new MultiselectAction($this->datatableName); | ||
| $this->actions[] = $newAction->set($action); | ||
| return $this; |
Collaborator
There was a problem hiding this comment.
https://symfony.com/doc/current/contributing/code/standards.html
Add a blank line before return statements, unless the return is alone inside a statement-group (like an if statement);
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Symfony 4's PropertyAccessor uses primary add* method for adding properties, not set*. Since MultiselectColumn is derived from ActionColumn and MultiselectColumn didn't have a addAction method, PropertyAccessor uses addAction method from ActionColumn class, that creates Action objects, not MultiselectAction objects.