Skip to content

Add support for css.resolve and css.global from styled-jsx#68

Merged
fleischie merged 1 commit into
styled-components:mainfrom
Simounet:feat/styled-jsx
Aug 5, 2019
Merged

Add support for css.resolve and css.global from styled-jsx#68
fleischie merged 1 commit into
styled-components:mainfrom
Simounet:feat/styled-jsx

Conversation

@Simounet
Copy link
Copy Markdown
Contributor

@Simounet Simounet commented Aug 2, 2019

Hi,
I added the support for css.resolve and css.global from styled-jsx. Fix #67.
Hope this is ok.
Have a nice day.

@Simounet Simounet changed the title #Fix 67 Add support for css.resolve and css.global from styled-jsx Fix #67 Add support for css.resolve and css.global from styled-jsx Aug 2, 2019
@Simounet Simounet changed the title Fix #67 Add support for css.resolve and css.global from styled-jsx Add support for css.resolve and css.global from styled-jsx Aug 2, 2019
@fleischie
Copy link
Copy Markdown
Collaborator

Hey @Simounet

thanks for your contribution. 🙏 One small inquiries: Could you add an example file, that illustrates the syntax highlighting capabilities for your change (similar to example/issue-66.ts just for css.resolve/css.global).

@Simounet
Copy link
Copy Markdown
Contributor Author

Simounet commented Aug 5, 2019

I just pushed it. Hope this is ok.

@fleischie fleischie merged commit 35291e5 into styled-components:main Aug 5, 2019
@fleischie
Copy link
Copy Markdown
Collaborator

I made a mistake and had to manually add your PR to develop again afterwards, just fyi. I will cut a release now with it, though. 😅

@Simounet Simounet deleted the feat/styled-jsx branch August 5, 2019 10:46
@Simounet
Copy link
Copy Markdown
Contributor Author

Simounet commented Aug 5, 2019

No worries and thanks for this quick support!
Have a nice day.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

styled-jsx resolve handling

2 participants