refactor: Remove outline card variant and update border colors#170
Merged
alexgrozav merged 2 commits intomainfrom Apr 5, 2026
Merged
refactor: Remove outline card variant and update border colors#170alexgrozav merged 2 commits intomainfrom
alexgrozav merged 2 commits intomainfrom
Conversation
The outline variant (border-only, no background) doesn't make sense for a card component. Removes it from all 4 card recipes, tests, storybook stories, Vue components, and documentation.
|
| Name | Type |
|---|---|
| @styleframe/theme | Minor |
| styleframe | Minor |
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
outlinevariant from all Card recipes (card, header, body, footer), reducing compound variants from 12 to 9 (3 colors × 3 variants)gray-800→gray-700,gray-300→gray-200)useCardBodyRecipeby removing all compound variants and border properties from base styles:has(+ .card-*)selectors to:first-child/:last-child