Add support for async templates #21
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bebraw
reviewed
Jan 8, 2020
bebraw
requested changes
Jan 15, 2020
Collaborator
bebraw
left a comment
bebraw
left a comment
There was a problem hiding this comment.
Can you document the feature at readme? I think it's good to go after that.
sapegin
approved these changes
Jan 28, 2020
bebraw
approved these changes
Jan 28, 2020
Collaborator
|
@sapegin Any idea why the semantic release bot didn't catch this one? |
Member
|
You can always check the logs ;-) |
Member
|
There's no tag in the commit. |
Collaborator
|
Ah, I see. That's what the 🗣was about at #20 then? What's the correct way to trigger the bot manually? |
Member
|
For example, make and empty commit ( |
Collaborator
|
Ok, got it. Just realized it wasn’t following the commit convention.
… On 29. Jan 2020, at 8.39, Artem Sapegin ***@***.***> wrote:
For example, make and empty commit (--allow-empty) with a correct tag (feat: XXXX).
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
Member
|
🎉 This PR is included in version 2.2.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simply: allow a
templatefunction to return a promise of a string.