Fix stuck navigations on repo issue detail and new issue pages#101
Merged
Fix stuck navigations on repo issue detail and new issue pages#101
Conversation
…hecks issues.tsx acted as an unintended layout parent for issues.$issueId.tsx due to TanStack Router dot-notation, but never rendered <Outlet />, so child routes had nowhere to mount — the URL changed but content froze. Renamed to issues.index.tsx to make it a sibling index route. Also added defaultPendingComponent for immediate loading feedback on all transitions and cached the _protected beforeLoad auth result to eliminate redundant server round-trips on every in-app navigation.
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
diffkit | 9733f59 | Apr 13 2026, 09:03 PM |
stylessh
added a commit
that referenced
this pull request
Apr 18, 2026
…hecks (#101) issues.tsx acted as an unintended layout parent for issues.$issueId.tsx due to TanStack Router dot-notation, but never rendered <Outlet />, so child routes had nowhere to mount — the URL changed but content froze. Renamed to issues.index.tsx to make it a sibling index route. Also added defaultPendingComponent for immediate loading feedback on all transitions and cached the _protected beforeLoad auth result to eliminate redundant server round-trips on every in-app navigation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
issues.tsxwas unintentionally acting as a layout parent forissues.$issueId.tsxandissues.new.tsxdue to TanStack Router's dot-notation convention, but it never rendered<Outlet />— so child routes couldn't mount and the page froze with stale content while the URL updated. Renamed toissues.index.tsxto make it a sibling index route.defaultPendingComponentto the router config so every route transition immediately shows a loading spinner instead of freezing on the old page._protectedlayout: ThebeforeLoadwas making two sequential server round-trips (getSession+checkSetupComplete) on every in-app navigation. Now both run in parallel viaPromise.alland the result is cached for subsequent navigations.Test plan