Skip to content

[codex] Fix README screenshot asset URLs#109

Merged
stylessh merged 3 commits intostylessh:mainfrom
premsathisha:codex/fix-readme-screenshots
Apr 14, 2026
Merged

[codex] Fix README screenshot asset URLs#109
stylessh merged 3 commits intostylessh:mainfrom
premsathisha:codex/fix-readme-screenshots

Conversation

@premsathisha
Copy link
Copy Markdown
Contributor

Summary

  • fix repo README rendering so relative image assets resolve against GitHub raw content URLs
  • support both markdown image src and raw HTML source srcset assets used by screenshots
  • add focused coverage for root, root-relative, nested, absolute, and anchor URLs

Why

README screenshots were broken for repos that reference checked-in assets with relative paths, including the examples from #106.

Validation

  • pnpm --filter dashboard exec vitest run src/components/repo/repo-markdown-files.test.ts
  • pnpm --filter dashboard check-types
  • pnpm --filter @diffkit/ui check-types
  • targeted Biome checks for touched files
  • git diff --check
  • pnpm --filter dashboard build

@premsathisha premsathisha marked this pull request as ready for review April 14, 2026 00:25
Copy link
Copy Markdown
Owner

thanks @premsathisha for the contribution!

can you please share before/after images?

@premsathisha
Copy link
Copy Markdown
Contributor Author

Here is the before and after from one of my repo's @stylessh:

Screenshot 2026-04-13 at 6 10 43 PM Screenshot 2026-04-13 at 6 11 13 PM

Copy link
Copy Markdown
Owner

@stylessh stylessh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@cloudflare-workers-and-pages
Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Updated (UTC)
✅ Deployment successful!
View logs
diffkit f8a35a5 Apr 14 2026, 01:23 AM

@stylessh stylessh merged commit 9a1d850 into stylessh:main Apr 14, 2026
4 checks passed
@premsathisha premsathisha deleted the codex/fix-readme-screenshots branch April 14, 2026 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants