Skip to content

Add review comment threading, diff themes, and thread resolution#110

Merged
stylessh merged 1 commit intomainfrom
stylessh/review-comments-threads-resolve
Apr 14, 2026
Merged

Add review comment threading, diff themes, and thread resolution#110
stylessh merged 1 commit intomainfrom
stylessh/review-comments-threads-resolve

Conversation

@stylessh
Copy link
Copy Markdown
Owner

Summary

  • Custom QuickHub light/dark themes for @pierre/diffs, replacing unsafeCSS color hacks with proper registerCustomTheme integration using project design tokens
  • Threaded review comment containers with reply forms, inline reply CTA, and icon+spinner loading pattern across PR detail activity and review diff pages
  • Comment more-menu dropdown on hover (copy link, copy markdown, edit, hide, delete) with author-only destructive actions
  • Resolve/unresolve review thread support via GraphQL mutations (resolveReviewThread/unresolveReviewThread), with collapse-on-resolve behavior and chevron toggle in file headers
  • New server functions: editComment, deleteComment, editReviewComment, deleteReviewComment, minimizeComment, getReviewThreadStatuses, resolveReviewThread, unresolveReviewThread

Test plan

  • Verify custom diff themes render correctly in both light and dark mode on PR detail and review pages
  • Test comment more-menu: copy link, copy markdown work for all users; edit/hide/delete show only for comment author
  • Test reply flow: icon swaps to spinner during send, label stays static, query invalidates on success
  • Test resolve/unresolve: button toggles state, diff block collapses on resolve, chevron toggle expands/collapses
  • Verify resolved threads show "Resolved" badge in file header (detail page) and comment container (review page)

- Create custom QuickHub light/dark themes for @pierre/diffs, replacing
  color override unsafeCSS hacks with proper theme registration
- Add threaded comment containers with reply forms and inline reply CTA
  for both PR detail activity and review diff pages
- Add comment more-menu dropdown (copy link, copy markdown, edit, hide,
  delete) with author-only destructive actions
- Add resolve/unresolve thread support via GraphQL mutations with
  collapse-on-resolve behavior and toggle icon in file headers
- Add icon+spinner loading pattern to reply and send CTAs
@cloudflare-workers-and-pages
Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Updated (UTC)
✅ Deployment successful!
View logs
diffkit 4b77adf Apr 14 2026, 12:42 AM

@stylessh stylessh merged commit 846a07a into main Apr 14, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant