Skip to content

Improve renamed event layout in issue and PR timelines #115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kovsu wants to merge 2 commits into
base: main
Choose a base branch
from
+28 −20
Open

Improve renamed event layout in issue and PR timelines #115

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ca8d4dd
Improve renamed event layout in issue and PR timelines
kovsu Apr 14, 2026
78651a8
on multi-line entries, align avatar/icon to top
stylessh Apr 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 13 additions & 9 deletions apps/dashboard/src/components/issues/detail/issue-detail-activity.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -435,7 +435,7 @@ export function IssueDetailActivitySection({
<div
key={`${item.type}-${group.createdAt}`}
className={cn(
"flex items-center gap-1.5",
"flex items-start gap-1.5",
index === 0
? "pt-5"
: isConsecutiveEvent
Expand Down Expand Up @@ -487,7 +487,7 @@ export function IssueDetailActivitySection({
<div
key={`event-${event.event}-${event.id}-${event.createdAt}`}
className={cn(
"flex items-center gap-1.5",
"flex items-start gap-1.5",
index === 0 ? "pt-5" : isConsecutiveEvent ? "pt-2" : "pt-5",
isLastInEventRun ? "pb-5" : "pb-2",
)}
Expand Down Expand Up @@ -792,13 +792,17 @@ function getIssueEventDescription(event: TimelineEvent): React.ReactNode {
);
case "renamed":
return (
<span className="inline-flex items-center gap-1">
<ActorMention actor={event.actor} hideAvatar />
{" changed the title from "}
<span className="line-through">{event.rename?.from}</span>
{" to "}
<span className="font-medium text-foreground">
{event.rename?.to}
<span className="flex min-w-0 flex-col gap-0.5">
<span>
<ActorMention actor={event.actor} hideAvatar />
{" changed the title"}
</span>
<span className="wrap-break-word">
<span className="line-through">{event.rename?.from}</span>
{" to "}
<span className="font-medium text-foreground">
{event.rename?.to}
</span>
</span>
</span>
);
Expand Down
26 changes: 15 additions & 11 deletions apps/dashboard/src/components/pulls/detail/pull-detail-activity.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1628,7 +1628,7 @@ function ActivityTimeline({
<div
key={`commit-${commit.sha}`}
className={cn(
"flex items-center gap-1.5",
"flex items-start gap-1.5",
index === 0 ? "pt-5" : isConsecutiveCommit ? "pt-2" : "pt-5",
isLastInCommitRun ? "pb-5" : "pb-2",
)}
Expand Down Expand Up @@ -1668,7 +1668,7 @@ function ActivityTimeline({
<div
key="merged"
className={cn(
"flex items-center gap-1.5 pb-5",
"flex items-start gap-1.5 pb-5",
index === 0 ? "pt-5" : "pt-5",
)}
>
Expand Down Expand Up @@ -1733,7 +1733,7 @@ function ActivityTimeline({
<div
key={`${item.type}-${group.createdAt}`}
className={cn(
"flex items-center gap-1.5",
"flex items-start gap-1.5",
index === 0 ? "pt-5" : isConsecutiveEvent ? "pt-2" : "pt-5",
isLastInEventRun ? "pb-5" : "pb-2",
)}
Expand Down Expand Up @@ -1958,7 +1958,7 @@ function TimelineEventRow({
return (
<div
className={cn(
"flex items-center gap-1.5",
"flex items-start gap-1.5",
isFirst ? "pt-5" : isConsecutive ? "pt-2" : "pt-5",
isLastInRun ? "pb-5" : "pb-2",
)}
Expand Down Expand Up @@ -2631,13 +2631,17 @@ function getEventDescription(
}
case "renamed":
return (
<span className="inline-flex items-center gap-1">
<ActorMention actor={event.actor} hideAvatar />
{" changed the title from "}
<span className="line-through">{event.rename?.from}</span>
{" to "}
<span className="font-medium text-foreground">
{event.rename?.to}
<span className="flex min-w-0 flex-col gap-0.5">
<span>
<ActorMention actor={event.actor} hideAvatar />
{" changed the title"}
</span>
<span className="wrap-break-word">
<span className="line-through">{event.rename?.from}</span>
{" to "}
<span className="font-medium text-foreground">
{event.rename?.to}
</span>
</span>
</span>
);
Expand Down