Open
Conversation
ccd9828 to
4d848e4
Compare
Contributor
Author
|
I overall heavily dislike the current manifest.json situation, imho it shouldn't be an asset, but instead be generated at runtime, for things such as theme colors, and other PWA features which require the origin to be specified |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
adds a launch_handler, and a lanchqueue consumer
the goal of this is to have new URLs opened externally [or internally], create new tabs in the already open client, rather than open a new one, for example: some1 on discord sends a github link, extension catches it, opens diffkit, but instead it opens it as a new tab, or some1 on discord sends a diffkit link directly, then the browser handles that directly
More details in the spec: https://github.com/WICG/web-app-launch/blob/main/launch_handler.md
not familiar with the codebase so this maybe could be done better? idk
there are ways to do this without the launchqueue, via serviceworkers, but that's effort, and would require actually writing react code, which I'm 50/50 on
Test Plan
Creates dummy launch queue, since it's a native api
Screenshots
Not applicable
This was like 70% AI coded with supervision, because React, and god I hate React, feel free to deny the PR for that, but the general idea is there.