Adding wrangler.jsonc to gitignore#147
Closed
gregor-tokarev wants to merge 7 commits intostylessh:mainfrom
Closed
Conversation
# Conflicts: # apps/dashboard/src/routes/_protected/settings/shortcuts.tsx
Contributor
|
Caution Review failedPull request was closed or merged during review 📝 WalkthroughWalkthroughThe pull request updates Wrangler resource identifiers for the dashboard application and configures Git to ignore the Wrangler configuration file. The database binding ID and two KV namespace identifiers have been modified in the configuration. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adding wrangler.jsonc to gitignore
This file should be in gitignore because it specifies database ids and kv ids. And for every contributor these values will be different, so they shouldn't be in code history
Changes
Summary by CodeRabbit