fix(dashboard): keep My pulls/issues/reviews updating on all tabs#160
Merged
fix(dashboard): keep My pulls/issues/reviews updating on all tabs#160
Conversation
Merge MyPulls, MyIssues, and MyReviews (pulls.mine) targets into the signal stream on every route so tab badges and lists stay fresh when viewing PR/issue detail or review.
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughAdded logic to derive a GitHub query scope from stream targets and merge additional "My" list targets (pulls.mine and issues.mine) into the subscription set, with de-duplication by signature, then use these merged targets in the WebSocket and polling invalidation paths. Changes
Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
This was referenced Apr 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The GitHub WebSocket signal stream and polling fallback now always subscribe to
pulls.mineandissues.mine, and register invalidate targets for the corresponding React Query keys, in addition to any route-specific targets.Why
On PR detail, issue detail, or review routes, the stream previously only tracked entity-scoped signals. My lists (pulls, issues, and the review queue derived from pulls) could go stale while those tabs were open because we never subscribed to the aggregate revalidation keys.
Implementation
useGitHubSignalStreammerges default targets forgithubQueryKeys.pulls.mineandgithubQueryKeys.issues.mineafter resolvinguserIdfrom any existing GitHub query key in the caller's targets.Summary by CodeRabbit