Skip to content

Add loading screen for uncached pages and fix UI polish#48

Merged
stylessh merged 1 commit intomainfrom
stylessh/loading-screen
Apr 10, 2026
Merged

Add loading screen for uncached pages and fix UI polish#48
stylessh merged 1 commit intomainfrom
stylessh/loading-screen

Conversation

@stylessh
Copy link
Copy Markdown
Owner

Summary

  • Add pendingComponent with defaultPendingMs: 0 to list routes (overview, pulls, issues, reviews) so a spinner shows immediately while loaders fetch on cold loads — cached navigations resolve instantly with no flash
  • Prefetch viewer query in pull detail loader to eliminate the "review requested" banner layout shift on hard reload
  • Remove double border on review page resizable panel (sidebar border-r clashed with ResizableHandle)

Test plan

  • Hard reload a list page without cache — spinner should show in content card center
  • Navigate between cached list pages — no spinner flash, content appears instantly
  • Hard reload a PR detail page with a review request — banner should render without layout shift
  • Open review page — no double border between file tree and diff panel

- Add pendingComponent to list routes (overview, pulls, issues, reviews) so a spinner shows while loaders fetch data on cold loads
- Set defaultPendingMs: 0 on the router for instant pending UI
- Simplify component loading fallbacks to show spinner during SSR-to-hydration gap
- Prefetch viewer query in pull detail loader to prevent review-requested banner layout shift
- Remove double border on review page resizable panel handle
@cloudflare-workers-and-pages
Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
diffkit 2033fac Commit Preview URL

Branch Preview URL
Apr 10 2026, 02:50 AM

@stylessh stylessh merged commit 560e902 into main Apr 10, 2026
4 checks passed
stylessh added a commit that referenced this pull request Apr 18, 2026
- Add pendingComponent to list routes (overview, pulls, issues, reviews) so a spinner shows while loaders fetch data on cold loads
- Set defaultPendingMs: 0 on the router for instant pending UI
- Simplify component loading fallbacks to show spinner during SSR-to-hydration gap
- Prefetch viewer query in pull detail loader to prevent review-requested banner layout shift
- Remove double border on review page resizable panel handle
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant