Skip to content

Fix detail pages hanging on Cloudflare Workers#65

Merged
stylessh merged 1 commit intomainfrom
stylessh/fix-pull-detail-hang
Apr 11, 2026
Merged

Fix detail pages hanging on Cloudflare Workers#65
stylessh merged 1 commit intomainfrom
stylessh/fix-pull-detail-hang

Conversation

@stylessh
Copy link
Copy Markdown
Owner

Summary

  • Detail page loaders (pull.$pullId, review.$pullId, issues.$issueId) used ensureQueryData which blocked rendering on async server function calls
  • On Cloudflare Workers, these created cross-request promises that crashed the Worker (Error 1101) and returned undefined to the client, causing blank pages
  • Replaced async loaders with synchronous getQueryData cache reads — components already fetch client-side via useQuery with skeletons and error boundaries
  • Added pendingComponent: DashboardContentLoading to all three detail routes

Test plan

  • Visit a pull detail page directly by URL (cold load) — should show spinner then content
  • Navigate from pulls list to pull detail — should use cached data instantly
  • Same for issue and review detail pages
  • Verify no cross-request promise warnings in Cloudflare Workers logs

Route loaders for pull, issue, and review detail pages used
ensureQueryData which blocked rendering on server function calls.
On Cloudflare Workers, these async operations created cross-request
promises that crashed the Worker (Error 1101) and returned undefined
data to the client, causing infinite loading.

Replace async loaders with synchronous cache reads via getQueryData.
Components already fetch data client-side via useQuery with proper
skeleton and error boundary handling. Add pendingComponent to all
three detail routes for loading feedback during navigation.
@cloudflare-workers-and-pages
Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
diffkit 11a55d1 Commit Preview URL

Branch Preview URL
Apr 11 2026, 05:23 AM

@stylessh stylessh merged commit a9d42f7 into main Apr 11, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant