Skip to content

next#145

Merged
KinjiKawaguchi merged 2 commits intomainfrom
develop
Apr 4, 2026
Merged

next#145
KinjiKawaguchi merged 2 commits intomainfrom
develop

Conversation

@KinjiKawaguchi
Copy link
Copy Markdown
Member

@KinjiKawaguchi KinjiKawaguchi commented Apr 4, 2026

KinjiKawaguchi and others added 2 commits April 2, 2026 11:56
<!-- devin-review-badge-begin -->

---

<a href="https://app.devin.ai/review/su-its/core/pull/142"
target="_blank">
  <picture>
<source media="(prefers-color-scheme: dark)"
srcset="https://static.devin.ai/assets/gh-open-in-devin-review-dark.svg?v=1">
<img
src="https://static.devin.ai/assets/gh-open-in-devin-review-light.svg?v=1"
alt="Open with Devin">
  </picture>
</a>
<!-- devin-review-badge-end -->
## Summary
- Prismaからの移行は完了済みのため、不要になった `_prisma_migrations` テーブルのスキーマ定義とデータを削除
- Drizzleマイグレーション(`DROP TABLE "_prisma_migrations" CASCADE`)を生成


🤖 Generated with [Claude Code](https://claude.com/claude-code)
<!-- devin-review-badge-begin -->

---

<a href="https://app.devin.ai/review/su-its/core/pull/144"
target="_blank">
  <picture>
<source media="(prefers-color-scheme: dark)"
srcset="https://static.devin.ai/assets/gh-open-in-devin-review-dark.svg?v=1">
<img
src="https://static.devin.ai/assets/gh-open-in-devin-review-light.svg?v=1"
alt="Open with Devin">
  </picture>
</a>
<!-- devin-review-badge-end -->

Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Copilot AI review requested due to automatic review settings April 4, 2026 03:30
Copy link
Copy Markdown

@devin-ai-integration devin-ai-integration Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Open in Devin Review

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes legacy Prisma migration artifacts from the Drizzle-managed schema and adds a Drizzle migration to drop the _prisma_migrations table so the database state matches the current Drizzle schema.

Changes:

  • Delete the _prisma_migrations table definition from the Drizzle schema.
  • Add migration 0004_loose_wasp to drop _prisma_migrations.
  • Record the updated Drizzle snapshot/journal metadata for migration tracking.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
src/infrastructure/drizzle/schema.ts Removes the Drizzle table definition for _prisma_migrations.
drizzle/0004_loose_wasp.sql Adds SQL migration to drop the legacy Prisma migrations table.
drizzle/meta/_journal.json Registers the new migration entry in Drizzle’s journal.
drizzle/meta/0004_snapshot.json Adds the schema snapshot reflecting removal of _prisma_migrations.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@@ -0,0 +1 @@
DROP TABLE "_prisma_migrations" CASCADE; No newline at end of file
Copy link

Copilot AI Apr 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DROP TABLE "_prisma_migrations" CASCADE; will fail in environments where the table is already missing (e.g., someone manually removed it or a DB was created without the legacy Prisma artifacts). Consider using DROP TABLE IF EXISTS and avoid CASCADE unless you’ve verified there are dependent objects you intentionally want to remove; CASCADE can drop unexpected dependent views/constraints.

Suggested change
DROP TABLE "_prisma_migrations" CASCADE;
DROP TABLE IF EXISTS "_prisma_migrations";

Copilot uses AI. Check for mistakes.
@KinjiKawaguchi KinjiKawaguchi merged commit 24eb2a3 into main Apr 4, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants