refactor: Node.js Subpath Importsでモジュール境界を明確化#63
Merged
KinjiKawaguchi merged 3 commits intodevelopfrom Jan 30, 2026
Merged
Conversation
- infrastructure/drizzle: schema, client の公開を停止(内部詳細) - domain: 境界を超えるインポートを index.ts 経由に統一 - tsconfig: 未使用の @/* パスエイリアスを削除 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the module structure to clarify boundaries and hide internal implementation details, making the codebase more maintainable and better encapsulated.
Changes:
- Removed unused
@/*path alias from TypeScript configuration - Hid internal database implementation details (schema and client) from the infrastructure/drizzle module's public API
- Unified domain module imports to consistently use index.ts barrel exports
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tsconfig.json | Removed unused @/* path alias configuration including baseUrl and paths |
| src/infrastructure/drizzle/index.ts | Changed from wildcard exports to explicit repository-only exports, hiding schema.ts and client.ts |
| src/domain/aggregates/member/Member.ts | Updated imports to use barrel exports from index.ts for exceptions and value-objects modules |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- #domain, #application, #infrastructure のサブパスインポートを設定 - 全68ファイルのインポートを相対パスからサブパスインポートに変更 - moduleResolution を node16 に変更 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Node16 → NodeNext(将来のNode.js変更に自動対応) - exportsフィールド追加(self-referencing対応) - example用tsconfig追加 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Merged
KinjiKawaguchi
added a commit
that referenced
this pull request
Mar 23, 2026
Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
../../../domain) が可読性を下げていたWhat
#domain,#application,#infrastructure) を導入infrastructure/drizzle:schema.ts,client.tsの公開を停止(内部詳細として隠蔽)moduleResolutionをnode16に変更Before
After
🤖 Generated with Claude Code