ci: ビルド・型チェック・Lintワークフロー追加#71
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds three CI workflows to automate quality checks on pull requests and pushes to the main and develop branches. The workflows verify that the codebase builds correctly, passes TypeScript type checking, and conforms to linting standards using Biome.
Changes:
- Added build verification workflow that runs
npm run build - Added type checking workflow that runs
npm run typecheck - Added linting workflow that runs Biome checks
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| .github/workflows/build.yml | Verifies the project builds successfully using tsup |
| .github/workflows/typecheck.yml | Validates TypeScript types using tsc --noEmit |
| .github/workflows/lint.yml | Checks code quality and formatting using Biome |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| node-version: '22.x' | ||
| cache: 'npm' | ||
| - run: npm ci | ||
| - run: npx biome check . |
There was a problem hiding this comment.
Consider adding a "lint" script to package.json and using "npm run lint" here for consistency with the other workflows (build.yml and typecheck.yml), which use npm scripts. This would also make it easier for developers to run the same command locally. For example, add "lint": "biome check ." to the scripts section of package.json.
| - run: npx biome check . | |
| - run: npm run lint |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
KinjiKawaguchi
force-pushed
the
feat/ci-workflows
branch
from
11b2917 to
6d0767a
Compare
- build.yml: ビルド確認 - typecheck.yml: 型チェック - lint.yml: Biomeによるlint PR・push時に並列実行される Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Add lint, lint:ci, format scripts to package.json - Use npm run lint:ci in CI for proper CI output Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
KinjiKawaguchi
force-pushed
the
feat/ci-workflows
branch
from
6d0767a to
a5d432d
Compare
Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
Summary
PR・push時に実行されるCIワークフローを追加
build.yml: ビルド確認typecheck.yml: TypeScript型チェックlint.yml: Biomeによるlintトリガー
🤖 Generated with Claude Code