Fix for nDim initialization causing macos builds in develop#1113
Merged
WallyMaier merged 1 commit intodevelopfrom Nov 23, 2020
Merged
Fix for nDim initialization causing macos builds in develop#1113WallyMaier merged 1 commit intodevelopfrom
WallyMaier merged 1 commit intodevelopfrom
Conversation
economon
approved these changes
Nov 23, 2020
Member
economon
left a comment
economon
left a comment
There was a problem hiding this comment.
Building fine now on macOS.
Btw, there are quite a few unused private field warnings in the NEMO numerics headers. Worth cleaning up in a future PR when you have some time.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The fixes a change made by #1111
The changes passed regressions however during the macos builds in develop.
I spoke with @economon and this should fix the problem.
Related Work
#1111