Fix compiler warnings#1138
Merged
pcarruscag merged 1 commit intodevelopfrom Dec 18, 2020
Merged
Conversation
Member
pcarruscag
commented
Dec 18, 2020
pcarruscag
commented
- My contribution generates no new compiler warnings (try with the '-Wall -Wextra -Wno-unused-parameter -Wno-empty-body' compiler flags, or simply --warnlevel=2 when using meson).
pcarruscag
commented
Dec 18, 2020
Comment on lines
-991
to
+992
| RHOCVTR_INDEX, RHOCVVE_INDEX; | ||
| unsigned short T_INDEX, TVE_INDEX, VEL_INDEX, RHOCVTR_INDEX; |
Member
Author
There was a problem hiding this comment.
@WallyMaier @CatarinaGarbacz there is a bug here, RHOCVTR_INDEX is used below but not initialized.
Contributor
There was a problem hiding this comment.
@pcarruscag Thanks for catching. Ill take a look.
Also, thank you for catching all those spacing issues and such in NEMO!
Member
Author
There was a problem hiding this comment.
The IDE does the spaces for me :)
pr-triage
Bot
added
PR: merged
PR: unreviewed
and removed
PR: unreviewed
PR: merged
labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.