Small misc fixes#1664
Merged
pcarruscag merged 7 commits intodevelopfrom Jun 16, 2022
Merged
Conversation
bigfooted
reviewed
Jun 9, 2022
bigfooted
reviewed
Jun 9, 2022
Contributor
|
Poiseuille_profile is now failing with very small changes in residuals. Is this due to the PR? We sometimes have these failures due to very strict comparison of residuals, so could be that. |
bigfooted
approved these changes
Jun 10, 2022
Contributor
bigfooted
left a comment
bigfooted
left a comment
There was a problem hiding this comment.
LGTM, Thank you for your service!
Member
Author
|
It's probably just the extra division or extra brackets but I'll make sure it's not the initialization of the arrays. |
TobiKattmann
approved these changes
Jun 10, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Leftovers from other PR's