Skip to content

Comments

Fix cli11 cstdint#2735

Merged
pcarruscag merged 1 commit intosu2code:developfrom
kanakaero:fix-cli11-cstdint
Feb 23, 2026
Merged

Fix cli11 cstdint#2735
pcarruscag merged 1 commit intosu2code:developfrom
kanakaero:fix-cli11-cstdint

Conversation

@kanakaero
Copy link

@kanakaero kanakaero commented Feb 22, 2026

Proposed Changes

Add a missing include to the vendored CLI11 header.

GCC 14+ no longer permits transitive inclusion of fixed-width integer types. CLI11.hpp uses uint64_t without including <cstdint>, which causes build failures with GCC 15.

Related Work

None

PR Checklist

Put an X by all that apply. You can fill this out after submitting the PR. If you have any questions, don't hesitate to ask! We want to help. These are a guide for you to know what the reviewers will be looking for in your contribution.

  • I am submitting my contribution to the develop branch.
  • My contribution generates no new compiler warnings (try with --warnlevel=3 when using meson).
  • My contribution is commented and consistent with SU2 style (https://su2code.github.io/docs_v7/Style-Guide/).
  • I used the pre-commit hook to prevent dirty commits and used pre-commit run --all to format old commits.
  • I have added a test case that demonstrates my contribution, if necessary.
  • I have updated appropriate documentation (Tutorials, Docs Page, config_template.cpp), if necessary.

@kanakaero kanakaero changed the base branch from master to develop February 22, 2026 18:17
@pcarruscag
Copy link
Member

Thanks for the fix.
We should try to use the current version of CLI11 and integrate it as a submodule like we do with other github-based dependencies. If you are looking for simple things to do in SU2, this would be one.

@pcarruscag pcarruscag merged commit 8204b8b into su2code:develop Feb 23, 2026
38 checks passed
@kanakaero
Copy link
Author

Yeah, that would be a better long term approach, I will look into it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants