Skip to content

Simplify OMP min/max reductions, cleanup raw indexing into CSysVector#2770

Merged
pcarruscag merged 6 commits intodevelopfrom
pedro/cleanup_omp_critical
Mar 30, 2026
Merged

Simplify OMP min/max reductions, cleanup raw indexing into CSysVector#2770
pcarruscag merged 6 commits intodevelopfrom
pedro/cleanup_omp_critical

Conversation

@pcarruscag
Copy link
Copy Markdown
Member

Proposed Changes

OpenMP 5.1 allows more efficient min/max than how we were doing them.
Also cleaned up CSysVector[i * n + j] to just CSysVector(i, j)

PR Checklist

  • I am submitting my contribution to the develop branch.
  • My contribution generates no new compiler warnings (try with --warnlevel=3 when using meson).
  • My contribution is commented and consistent with SU2 style (https://su2code.github.io/docs_v7/Style-Guide/).
  • I used the pre-commit hook to prevent dirty commits and used pre-commit run --all to format old commits.
  • I have added a test case that demonstrates my contribution, if necessary.
  • I have updated appropriate documentation (Tutorials, Docs Page, config_template.cpp), if necessary.

Comment thread Common/src/grid_movement/CLinearElasticity.cpp Outdated
@pcarruscag pcarruscag merged commit 8d29847 into develop Mar 30, 2026
37 checks passed
@pcarruscag pcarruscag deleted the pedro/cleanup_omp_critical branch March 30, 2026 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant