Skip to content

Store matrices in LDU format to improve performance of LU-SGS and ILU preconditioners#2838

Merged
pcarruscag merged 16 commits into
developfrom
pedro/ldu
Jul 5, 2026
Merged

Store matrices in LDU format to improve performance of LU-SGS and ILU preconditioners#2838
pcarruscag merged 16 commits into
developfrom
pedro/ldu

Conversation

@pcarruscag

@pcarruscag pcarruscag commented Jun 29, 2026

Copy link
Copy Markdown
Member

Proposed Changes

Store matrices in LDU format
On a representative 3D case (one of the HLCRM meshes):
Time per iteration with ILU: 2.65s -> 2.4s
Time per iteration with LU_SGS: 2.05s -> 1.85s

I was not very careful in making sure these profiles were 100% apples to apples by covering the same number of iterations but they show the preconditioner time is not much closer to the matrix-vector product.
ILU develop:
ilu_dev
ILU using LDU format
ilu_new
SGS develop:
lu_sgs_dev
SGS using LDU format:
lu_sgs_new

Related Work

Closes #2837

PR Checklist

  • I am submitting my contribution to the develop branch.
  • My contribution generates no new compiler warnings (try with --warnlevel=3 when using meson).
  • My contribution is commented and consistent with SU2 style (https://su2code.github.io/docs_v7/Style-Guide/).
  • I used the pre-commit hook to prevent dirty commits and used pre-commit run --all to format old commits.
  • I have added a test case that demonstrates my contribution, if necessary.
  • I have updated appropriate documentation (Tutorials, Docs Page, config_template.cpp), if necessary.

@pcarruscag pcarruscag changed the title [WIP] Store matrices in LDU format to improve performance of LU-SGS and ILU preconditioners Store matrices in LDU format to improve performance of LU-SGS and ILU preconditioners Jul 3, 2026
@pcarruscag pcarruscag marked this pull request as ready for review July 3, 2026 21:50
Comment thread TestCases/euler/oneram6/inv_ONERAM6.cfg Outdated
@pcarruscag pcarruscag merged commit c3d7563 into develop Jul 5, 2026
7 of 26 checks passed
@pcarruscag pcarruscag deleted the pedro/ldu branch July 5, 2026 04:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant