Skip to content

Conversation

@WenyinWei
Copy link

No description provided.

@WenyinWei
Copy link
Author

Hello all,

Would you mind changing full names of all physical variables to symbols? Or give symbols first, with full names behind them. That would make the tutorial more readable for readers with hydrodynamics background knowledge.

@economon
Copy link
Member

Hi @WenyinWei : I am not sure I understand your request fully, but please don't hesitate to propose any changes you would like. We really would like to encourage more collaboration on the documentation through GitHub as well (like we have for the code already). Thanks!

@WenyinWei
Copy link
Author

Oh, I should have added some more info in the conversation panel. The pull request is initialized due to a small typo of the stagnation pressure & temperature. It is just a small typo 8437b5a and I will report more in this pull request. Additionally, would you like to change the variable names appearing in the .md files to their conventional symbols in fluid dynamics, that would be much more understandable and concise? A table of the variable names can be added at the beginning of the end of the page.

@economon
Copy link
Member

@WenyinWei : we're happy to consider any changes you would like to make if you feel it makes the documentation more clear. Thanks for helping improve the docs

@WenyinWei
Copy link
Author

Oh, sorry for being late to edit, I will add more these days. Thanks for your remind~

@TobiKattmann
Copy link
Contributor

TobiKattmann commented Nov 13, 2020

I'll merge this in now as this fixes a mistake... and quite some time passed without any movement here :)

Thanks for the contribution @WenyinWei 💐 if you're still interested in adding a version with more symbols I would ask you just to open a new PR. I do like the idea of adding more symbols because it is much more intuitive to understand at a glance. Adding latex style formulas is pretty straight forward just put the LaTeX code into double dollar like so $$\rho$$

@TobiKattmann TobiKattmann merged commit 1dea474 into su2code:master Nov 13, 2020
@pr-triage pr-triage bot added the PR: merged label Nov 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants