Tutorials for unsteady FSI with Python wrapper and Nastran structure #46
Conversation
update develop
update develop
Added the unsteady fsi entry
pcarruscag
left a comment
pcarruscag
left a comment
There was a problem hiding this comment.
Very nice 👍 I'm having some issues with the preview, if you want we can merge directly to master to see it in the website.
| NMODES (int): number of modes to use in the analysis. If n modes are available in | ||
| the punch file, but only the first m<n are required, set this to m | ||
|
|
||
| IMPOSED_MODE (int): mode with an imposed motion. The first index, consistent with Python syntax, is 0 | ||
|
|
||
| RESTART_ITER (int): if restart is used, this specifies the iteration to restart |
There was a problem hiding this comment.
I would maybe emphasize the keywords somehow, maybe bold letters.
There was a problem hiding this comment.
Yes you are right, I will change that
|  | ||
|
|
There was a problem hiding this comment.
I tried to preview the tutorial here (https://github.com/Nicola-Fonzi/su2code_website/blob/develop/_tutorials/multiphysics/Unsteady_FSI_Python/Dynamic_FSI_Python.md)
But the images are not being displayed, maybe there is some issue with the syntax.
There was a problem hiding this comment.
I tried to already use the paths that the images should have once the merging process is completed. Maybe they are not displayed until this is done.
| #### Mesh Description | ||
|
|
||
| The fluid domain is discretised with 133k nodes, with refining close to the airfoil surface, in order to correctly represent the turbulent boundary layer. The first cell | ||
| is placed at a height of $$y+\approx 1$$. A close up view of the mesh is pictured below: |
There was a problem hiding this comment.
The bits in $$ $$ don't show with any formatting in the preview. Have you seen this in other tutorials? Maybe they are shown correctly on the website but not with the preview.
There was a problem hiding this comment.
I actually saw them here, which is the tutorial I mention in the .md file.
|
I can try to change the font of the keywords and then, if it is fine for you, merging in master would be perfect to see how it is displayed |
|
Go for it. |
|
Ok the fonts are changed. I noticed that, as I branched from the develop of your repo, there are two your commits that are not present in master. The very first two commits of this PR. Is it a problem? |
|
It should be fine |
|
Perfect, is there something needed from my side to start merging? Sorry, as I said it is the first time I actually work with github so I am not sure... |
|
Nop, if the merge button shows as green, it is good to go. |
|
It is already online! Pictures appears as expected, I just did one latex statement incorrect, fixing it now |
|
...I thought I had time until tomorrow to look over this :D but things move faster than old Tobi can process 👴 for completeness: You can host the website locally using jekyll to test everything before pushing |
|
Thanks for the tip about jekyll, I will have a look at that! |
3 participants
PR related to pull request #1124 in the SU2 repo