Skip to content
This repository was archived by the owner on Aug 11, 2024. It is now read-only.

Attempt to include the DID if indexPeer fails#930

Merged
gordonbrander merged 2 commits intomainfrom
2023-10-12-include-did-in-fail-index
Oct 13, 2023
Merged

Attempt to include the DID if indexPeer fails#930
gordonbrander merged 2 commits intomainfrom
2023-10-12-include-did-in-fail-index

Conversation

@bfollington
Copy link
Copy Markdown
Collaborator

@bfollington bfollington commented Oct 12, 2023

Fixes #927

We cannot always guarantee that the identity is available (or even exists) but we can make a best-effort to include the identity for debugging purposes.

We cannot always guarantee that the identity is available (or even exists) but we can make a best-effort to include the identity for debugging purposes.
@bfollington bfollington marked this pull request as ready for review October 12, 2023 01:44
Copy link
Copy Markdown
Collaborator

@gordonbrander gordonbrander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion

Comment thread xcode/Subconscious/Shared/Components/AppView.swift Outdated
Copy link
Copy Markdown
Collaborator

@gordonbrander gordonbrander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gordonbrander gordonbrander merged commit c802460 into main Oct 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

When a sphere fails to index, we don't see its did in the logs

2 participants