-
Notifications
You must be signed in to change notification settings - Fork 36
Add domain exclusion step to Tranco workflow #643
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
422df8f
Add domain exclusion step to Tranco workflow
aidenmitchell 5af6913
Fix integer comparison error in domain exclusion script
aidenmitchell 5215d2f
Fix domain exclusion to handle Windows line endings
aidenmitchell d26ac1e
Simplify domain exclusion by normalizing line endings first
aidenmitchell 4ddd871
Fix integer comparison error in domain counting
aidenmitchell 46d4118
Replace hardcoded exclusion list with Public Suffix List
aidenmitchell 4e0eb00
Address PR review feedback: improve performance, error handling, and …
aidenmitchell f4ef3c3
Update .github/workflows/update-and-process-tranco.yml
aidenmitchell File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.