Skip to content

Create attachment_ics_non-gregorian.yml #3444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Nov 4, 2025
Merged

Create attachment_ics_non-gregorian.yml #3444

merged 5 commits into from
Nov 4, 2025
+21 −0

Conversation

@zoomequipd
Copy link
Member

@zoomequipd zoomequipd commented Oct 30, 2025

Description

Add new coverage

Associated hunts

@zoomequipd zoomequipd requested a review from a team as a code owner October 30, 2025 02:39
@github-actions github-actions bot added the in-test-rules PR is in our testing suite to collect telemetry label Oct 30, 2025
github-actions bot added a commit that referenced this pull request Oct 30, 2025
@github-actions
[PR #3444] added rule: Attachment: ICS file with non-Gregorian calend…
515d9bd 
…ar scale
github-actions bot added a commit that referenced this pull request Oct 31, 2025
@github-actions
[PR #3444] modified rule: Attachment: ICS file with non-Gregorian cal…
04c2b90 
…endar scale
@zoomequipd zoomequipd added the review-needed Indicates that a PR is waiting for review label Nov 3, 2025
aidenmitchell
aidenmitchell approved these changes Nov 4, 2025
View reviewed changes
Copy link
Member

@aidenmitchell aidenmitchell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not worried either way, but should this be an ASR rule?

@zoomequipd
Copy link
Member Author

zoomequipd commented Nov 4, 2025

Not worried either way, but should this be an ASR rule?
I'd like to run it as a rule for now, can covert to ASR if needed, but looks good at this time.

github-actions bot added a commit that referenced this pull request Nov 4, 2025
@github-actions
[PR #3444] modified rule: Attachment: ICS file with non-Gregorian cal…
2a05003 
…endar scale
@zoomequipd zoomequipd added this pull request to the merge queue Nov 4, 2025
Merged via the queue into main with commit 7b63e41 Nov 4, 2025
3 checks passed
@zoomequipd zoomequipd deleted the zoomequipd.ics_non-gregorgian branch November 4, 2025 23:37
github-actions bot added a commit that referenced this pull request Nov 4, 2025
@github-actions
[PR #3444] Delete detection rule
cee9088
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aidenmitchell aidenmitchell aidenmitchell approved these changes

Assignees

No one assigned

Labels

in-test-rules PR is in our testing suite to collect telemetry review-needed Indicates that a PR is waiting for review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@zoomequipd @aidenmitchell