Skip to content

Conversation

@jack1902
Copy link

to:
cc: @subspacecommunity/subspace-maintainers
related to:
resolves: #123

Background

Keep forgetting to update the manifest so this means i no longer have to

Changes

  • Manifest is generated on each run of the post_push hook
  • version is grabbed from the release tag which will always be of the format vMAJOR.MINOR.BUGFIX

Testing

Ran the script locally and inspected the output 🎉

- Takes the git-version tag at runtime to generate the correct tags
@jack1902 jack1902 added the enhancement New feature or request label Jul 17, 2020
@jack1902 jack1902 self-assigned this Jul 17, 2020
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Collaborator

@agonbar agonbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on a linux machine, the file generated matches

@jack1902 jack1902 merged commit 407374a into master Jul 17, 2020
@jack1902 jack1902 deleted the fix/dockerhub-versioning branch July 17, 2020 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Correct Dockerhub Version Tags

4 participants