Skip to content

fix: use zstd instead of gzip for data source requests #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mo4islona merged 1 commit into from
Mar 25, 2026
Merged

fix: use zstd instead of gzip for data source requests #61

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion crates/data-client/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ edition = "2021"
anyhow = { workspace = true, features = ["std"] }
bytes = { workspace = true }
futures = { workspace = true }
reqwest = { workspace = true, features = ["gzip", "json", "stream"] }
reqwest = { workspace = true, features = ["zstd", "json", "stream"] }
Copy link

Copilot AI Mar 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dropping the gzip feature here removes gzip decompression support for this client. If data_sources can point to services that only support gzip (or return it despite Accept-Encoding), requests may start failing. Consider keeping both gzip and zstd features enabled for backward compatibility, unless all supported data sources are guaranteed to support zstd.

Suggested change
reqwest = { workspace = true, features = ["zstd", "json", "stream"] }
reqwest = { workspace = true, features = ["gzip", "zstd", "json", "stream"] }

Copilot uses AI. Check for mistakes.
serde = { workspace = true, features = ["derive"] }
serde_json = { workspace = true }
sqd-primitives = { path = "../primitives", features = ["serde"] }
2 changes: 1 addition & 1 deletion crates/data-client/src/reqwest/client.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ pub fn default_http_client() -> Client {
Client::builder()
.read_timeout(Duration::from_secs(20))
.connect_timeout(Duration::from_secs(20))
Copy link

Copilot AI Mar 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Switching the client to only advertise/handle zstd means data sources that don't support content-encoding: zstd (or that ignore Accept-Encoding and respond with gzip) will fail to decode. Since DatasetConfig.data_sources accepts arbitrary URLs, consider enabling both gzip and zstd support (keep the gzip feature and also call .gzip(true) alongside .zstd(true)), or make the encoding configurable if zstd-only is a hard requirement.

Suggested change
.connect_timeout(Duration::from_secs(20))
.connect_timeout(Duration::from_secs(20))
.gzip(true)

Copilot uses AI. Check for mistakes.
.gzip(true)
.zstd(true)
.build()
.unwrap()
}
Expand Down
Loading