Add repository to fields #34
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When editing a field we occasionally need to know the record being edited to properly render the field (for example to set default values based on other field values) or when listing options for a select field.
It is actually the repository we need to know for each field, much more than the individual record.
koppen
force-pushed
the
add_record_to_fields
branch
from
e66613a to
c0c7925
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds a repository accessor to the Field class and sets it when retrieving fields for different views (edit, index, show). However, there's an inconsistency in how the fields_for_edit method signature is being updated.
- Added
repositoryattribute toFieldclass to associate fields with their repository - Modified
fields_for_edit,fields_for_index, andfields_for_showto set the repository on each field - Updated test and controller to pass a record parameter to
fields_for_edit
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| lib/uchi/field.rb | Added repository accessor attribute to Field class |
| lib/uchi/repository.rb | Modified field retrieval methods to set repository on each field |
| test/uchi/repository_test.rb | Updated test to pass author record to fields_for_edit |
| app/controllers/uchi/repository_controller.rb | Updated controller to pass record to fields_for_edit |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
olepalm
approved these changes
Oct 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Each Field could benefit from knowing the Repository they're a part of