fix(isthmus): more standard SQL for TPCDS query 72#326
Merged
Blizzara merged 1 commit intosubstrait-io:mainfrom Feb 6, 2025
Merged
fix(isthmus): more standard SQL for TPCDS query 72#326Blizzara merged 1 commit intosubstrait-io:mainfrom
Blizzara merged 1 commit intosubstrait-io:mainfrom
Conversation
According to a related [Calcite issue](https://issues.apache.org/jira/browse/CALCITE-304), TPCDS query 72 uses Oracle-specific syntax for date addition, which defaults to days as the time unit when a numeric value is added to a date. A more standards-compliant form is to explicitly specify the time unit as an interval. Signed-off-by: Mark S. Lewis <Mark.S.Lewis@outlook.com>
Blizzara
approved these changes
Feb 6, 2025
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to a related Calcite issue, TPCDS query 72 uses Oracle-specific syntax for date addition, which defaults to days as the time unit when a numeric value is added to a date. A more standards-compliant form is to explicitly specify the time unit as an interval.
Relates to #72