chore(isthmus): remove dead code #604
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the use of DdlSqlToRelConverter was added to SubstraitSqlToCalcite in commit 260a1c4, the original invocation of SqlToRelConverter that was left as a fallback when it returns null is never called. The reason is that DdlSqlToRelConverter itself already falls back to calling SqlToRelConverter so it never returns null. This means that
removeRedundantProjectsis never applied to the Rel structure since this only occurs in the uncalled fallback path. All tests continue to pass, which indicates that this optimization is unnecessary.If it is required in the future, it might be better written as follows to provide flexibility in the rules applied: