breaking: removing emptyScan in favor of emptyVirtualTableScan #682
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ACTION NEEDED Substrait follows the Conventional Commits The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification. |
gord02
force-pushed
the
gordon.hamilton/removeEmptyScan
branch
from
a66fe19 to
0c267da
Compare
gord02
changed the title
benbellick
reviewed
Jan 20, 2026
Member
benbellick
left a comment
benbellick
left a comment
There was a problem hiding this comment.
all looks reasonable to me! Only thing really is just putting that roundtrip test back in.
Also, maybe we will want to mark this as a breaking change since we are technically modifying the API here by dropping a public class. @vbarua
benbellick
reviewed
Jan 21, 2026
core/src/main/java/io/substrait/relation/ProtoRelConverter.java
Outdated
Show resolved
Hide resolved
benbellick
reviewed
Jan 21, 2026
Member
benbellick
left a comment
benbellick
left a comment
There was a problem hiding this comment.
Just the one comment here and then I think it's great!
https://github.com/substrait-io/substrait-java/pull/682/files#r2712955699
gord02
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the EmptyScan and replaces it with empty VirtualTableScan.
Closes #673