feat(isthmus): add strptime_* function mappings #695
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Niels Pardon <par@zurich.ibm.com>
nielspardon
requested review from
andrew-coleman,
benbellick,
bestbeforetoday and
vbarua
bestbeforetoday
requested changes
Jan 30, 2026
Member
There was a problem hiding this comment.
There is quite a bit of duplication between the three Strptime function mapping and test implementations that might benefit from being factored out, perhaps into a StrptimeMapper superclass and using a parameterized test. It is fine as-is if you prefer to defer any refactoring to a future PR though.
Just a few unnecessary casts noted with inline comments that are worth removing to avoid redundant code.
isthmus/src/test/java/io/substrait/isthmus/FunctionConversionTest.java
Outdated
Show resolved
Hide resolved
isthmus/src/test/java/io/substrait/isthmus/FunctionConversionTest.java
Outdated
Show resolved
Hide resolved
isthmus/src/test/java/io/substrait/isthmus/FunctionConversionTest.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Mark S. Lewis <Mark.S.Lewis@outlook.com>
bestbeforetoday
approved these changes
Jan 30, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds Calcite mappings for the following 3 Substrait functions:
strptime_time->PARSE_TIMEstrptime_timestamp->PARSE_TIMESTAMPstrptime_date->PARSE_DATEI added the
ScalarFunctionConverterinto theRexExpressionConverterinstance inFunctionConversionTestin order to round-trip test Substrait <-> Calcite expression mappings which also made thesubtractDateIDaytest case work.The Calcite functions are Big Query specific variants which happen to be defined closest to the Substrait variants of this functions vs. other alternatives
TO_DATEandTO_TIMESTAMP.