Skip to content

feat: introduce Type#withNullable(boolean)#713

Merged
nielspardon merged 1 commit intomainfrom
vbarua/nullable-setting-visitor-cleanup
Mar 2, 2026
Merged

feat: introduce Type#withNullable(boolean)#713
nielspardon merged 1 commit intomainfrom
vbarua/nullable-setting-visitor-cleanup

Conversation

@vbarua
Copy link
Member

@vbarua vbarua commented Feb 27, 2026

No description provided.

Allows us to fully remove the NullableSettingTypeVisitor
@vbarua
Copy link
Member Author

vbarua commented Feb 27, 2026

@benbellick introduced a similar setter for Expressions, and I realized we could apply the same technique to Types and delete a bunch of code.

Copy link
Member

@benbellick benbellick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My favorite kind of PR :)

Copy link
Member

@nielspardon nielspardon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nielspardon nielspardon merged commit ea1a708 into main Mar 2, 2026
12 checks passed
@nielspardon nielspardon deleted the vbarua/nullable-setting-visitor-cleanup branch March 2, 2026 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants