Conversation
…arkupControllers are now responsible mainly for generating the html themselves and calling the renderers (which call up subsequent classes as needed). Also had Claude go through and re-org the import statements for clarity
…eak information shown when there is no live data instead of sharing ETA and DEP again
Contributor
Author
|
Normally MRs of this size shouldn't be done (whoops) got lost in the sauce |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a mildly large refactor.
Claude worked on creating more test scenarios for the test preview renderer, and one of the largest changes was modeling the WMATA controller and markup controller to behave more like the Flight Tracker. So, the renderer module was created which lets the controllers focus on...the controlling(?) of data. Everything has their own little spot basically.
Claude, as always, handled any large HTML updates.
Test cases were split out into formatters/renderers/statusMapper test modules
Also, plane SVG was updated to remove the engines (it looked weird) and we use the fa-airplane or something similar to Google's implementation