Conversation
…instead Once a flight has landed it still carries progressPct/minsRemaining, so the no-telemetry fallback rendered "ARRIVING IN / Arriving" for a flight that arrived hours ago. Add an isArrived() check and a shared progressTile() helper (used by full + half variants) that shows ARRIVED + the landing time in the terminal state. Adds a regression test and an "Arrived" preview scenario, and expands a few shorthand locals (cd -> countdownState, pt -> fallbackTile). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Patch fix for a regression where an Arrived flight (no live telemetry, but progressPct 100 / negative minsRemaining) rendered a stale
ARRIVING IN / Arrivingcountdown tile.isArrived()+ a sharedprogressTile()helper used by full and half variants; once landed the tile showsARRIVED+ the actual landing time.renderers.test.ts(full + half +Likely Arrived).cd→countdownState,pt→fallbackTile).50 tests pass, build clean.
🤖 Generated with Claude Code