Skip to content

Update package-lock.json and switch submodule to HTTP#92

Merged
taylorhadden merged 3 commits intosuchnsuch:mainfrom
k8ieone:main
Aug 29, 2024
Merged

Update package-lock.json and switch submodule to HTTP#92
taylorhadden merged 3 commits intosuchnsuch:mainfrom
k8ieone:main

Conversation

@k8ieone
Copy link
Contributor

@k8ieone k8ieone commented Aug 27, 2024

In order to get Flatpak builds working, I've had to make a few changes.

  1. Update package-lock.json
  2. Switch the Typewriter submodule to HTTP

I've had to switch from SSH because Github doesn't allow pulling from SSH unless you add the machine's SSH key to a Github account. Since the builds will run on Flathub's CI servers, this is not feasible.

In case you need write access to the submodule from the main repo, I recommend using insteadOf in your git config.

Example:

[url "ssh://git@github.com"]
	insteadOf = https://github.com

Related to #86

@taylorhadden
Copy link
Contributor

Good stuff!

That other package will need to be resolved at some point somehow. It's not exactly important, but it's part of the monorepo and will come back next time the lock file gets updated.

@taylorhadden taylorhadden merged commit a5c57f0 into suchnsuch:main Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants