Update package-lock.json and switch submodule to HTTP#92
Merged
taylorhadden merged 3 commits intosuchnsuch:mainfrom Aug 29, 2024
k8ieone:main
Merged
Update package-lock.json and switch submodule to HTTP#92taylorhadden merged 3 commits intosuchnsuch:mainfrom k8ieone:main
package-lock.json and switch submodule to HTTP#92taylorhadden merged 3 commits intosuchnsuch:mainfrom
k8ieone:main
Conversation
Contributor
|
Good stuff! That other package will need to be resolved at some point somehow. It's not exactly important, but it's part of the monorepo and will come back next time the lock file gets updated. |
taylorhadden
approved these changes
Aug 29, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order to get Flatpak builds working, I've had to make a few changes.
package-lock.jsonI've had to switch from SSH because Github doesn't allow pulling from SSH unless you add the machine's SSH key to a Github account. Since the builds will run on Flathub's CI servers, this is not feasible.
In case you need write access to the submodule from the main repo, I recommend using
insteadOfin your git config.Example:
Related to #86