Use accessor for getting an ASN1_STRING's length#483
Merged
millert merged 1 commit intosudo-project:mainfrom Nov 22, 2025
botovq:opaque-asn1-string
Merged
Use accessor for getting an ASN1_STRING's length#483millert merged 1 commit intosudo-project:mainfrom botovq:opaque-asn1-string
millert merged 1 commit intosudo-project:mainfrom
botovq:opaque-asn1-string
Conversation
OpensSSL 4 has plans to make ASN1_STRING opaque [1]. hostcheck.c's code mostly treats it as opaque, but accesses two lengths. This is API added in OpenSSL 0.9.0, so I'm not sure we need a configure check. WolfSSL only recently const corrected ASN1_STRING_length(), so maybe there will be a need to cast away const. [1]: openssl/openssl#29117
millert
approved these changes
Nov 22, 2025
Collaborator
millert
left a comment
millert
left a comment
There was a problem hiding this comment.
Looks good to me. I don't think the last of const in the wolfssl ASN1_STRING_length will be an issue, but it is easy to add the cast later if needed.
botovq
added a commit
to botovq/ports
that referenced
this pull request
Dec 4, 2025
botovq
added a commit
to botovq/ports-opaque-strings
that referenced
this pull request
Jan 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OpensSSL 4 has plans to make ASN1_STRING opaque. hostcheck.c's code mostly treats it as opaque, but accesses two lengths. This is API added in OpenSSL 0.9.0, so I'm not sure we need a configure check.
WolfSSL only recently const corrected ASN1_STRING_length(), so maybe there will be a need to cast away const.