fix: preserve mode-specific model selections across mode switches#225
Merged
fix: preserve mode-specific model selections across mode switches#225
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes issue #112 where mode switching via Alt+M does not respect model configuration from opencode.json. The fix introduces a user preference tracking system and improves the model selection priority logic.
Changes:
- Added
user_mode_model_mapstate field to track user's model selections per mode - Modified
switch_to_modeto use a priority system: user selection > mode config > global config - Removed state resets in
M.opento preserve mode/model selections across new sessions - Updated and added tests to validate the new priority-based model selection behavior
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| lua/opencode/state.lua | Adds user_mode_model_map field to track user's per-mode model selections |
| lua/opencode/core.lua | Updates model selection logic in switch_to_mode with priority system, stores user selections in configure_provider, removes state resets in M.open |
| tests/unit/core_spec.lua | Updates tests to initialize new state field, replaces old test with new tests validating priority-based model selection |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should fix #112