Conversation
881cfa1 to
2c946cc
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Adds diff gutter line numbers to the UI diff formatter output (rendered via extmarks), and updates test fixtures accordingly.
Changes:
- Update
formatter.format_diffto compute per-line old/new line numbers from hunk headers and render a gutter via overlay extmarks. - Add new diff gutter highlight groups for neutral/add/delete gutters.
- Update unit tests and expected JSON fixtures to reflect the new gutter/extmark output.
Reviewed changes
Copilot reviewed 9 out of 10 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
lua/opencode/ui/formatter.lua |
Parses diff hunks to compute line numbers and renders a line-number gutter via extmarks. |
lua/opencode/ui/highlight.lua |
Adds highlight groups for the new diff gutter styling. |
tests/unit/formatter_spec.lua |
Adds a unit test validating diff line numbers are rendered as extmarks. |
tests/data/shifting-and-multiple-perms.expected.json |
Updates expected extmarks/lines output to include gutter changes. |
tests/data/redo-once.expected.json |
Updates expected output for diff gutter and resulting display/action ranges. |
tests/data/redo-all.expected.json |
Updates expected output structure/ordering to match new rendered lines and gutter extmarks. |
tests/data/markdown-codefence.expected.json |
Updates expected extmarks/lines to include gutter rendering in diffs. |
tests/data/diff.expected.json |
Updates expected extmarks/lines for diff gutter behavior. |
tests/data/apply-patch.expected.json |
Expands and reorders expected JSON output to include gutter extmarks and formatted lines. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
e5e4baa to
4cd3aa9
Compare
4cd3aa9 to
8494070
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.