refactor: carefully set model from session#98
Merged
sudo-tee merged 1 commit intosudo-tee:mainfrom Nov 4, 2025
Merged
Conversation
When loading a session, clear state.current_model and set it to the model used by the most recent message. Topbar shouldn't set a model as a side effect, it should just display what's been selected. Add `core.initialize_current_model()` which will initialize state.current_model to the default from the config_file if it hasn't been set
Owner
|
Thanks for having a look at this. I wanted to have a look pretty soon. You beat me to it 😁. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When loading a session, clear state.current_model and set it to the model used by the most recent message.
Topbar shouldn't set a model as a side effect, it should just display what's been selected.
Add
core.initialize_current_model()which will initialize state.current_model to the default from the config_file if it hasn't been setI think this achieves the behavior described in #96 (comment):
state.current_modelto the model most recently used in that sessionstate.current_modelwill get re-initialized to the defaultstate.current_model