Add generic rest endpoint class for calling custom endpoints #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaelJ2324
requested changes
Sep 5, 2025
Contributor
MichaelJ2324
left a comment
MichaelJ2324
left a comment
There was a problem hiding this comment.
Add types please. Auth property can be set to optional as well. Also what's the use case you see for with headers method?
Contributor
Author
|
On the header method: I don't need it for my particular use case, but was going for completeness in that I think it'd be nice to be able to easily modify headers on a custom request. No problem taking it out for now though, as it's possible to do now, just a bit opaque. |
MichaelJ2324
approved these changes
Sep 15, 2025
Contributor
MichaelJ2324
left a comment
MichaelJ2324
left a comment
There was a problem hiding this comment.
Code quality fixed. Approved.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.